Media Editor: auto zoom-out during freeform crop handle drag#77538
Closed
ramonjd wants to merge 8 commits intoWordPress:trunkfrom
Closed
Media Editor: auto zoom-out during freeform crop handle drag#77538ramonjd wants to merge 8 commits intoWordPress:trunkfrom
ramonjd wants to merge 8 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zoom >= 1restored.How it works
A transient
isResizingflag gates a sub-unit-zoom regime in the cropper reducer:BEGIN_RESIZEon handle pointerdown relaxes thezoom >= 1floor and pinsbase*fields.handleCropChangedispatches a combinedSET_CROP_RECT+SET_ZOOMwhere zoom is computed so the growing crop fits the container with a small margin (RESIZE_FIT_MARGIN = 0.95).restrictPanZoomin containment skips the cover-floor bump while the flag is set — the camera math is linear and handleszoom < 1without modification (verified by test + JSDoc increateCamera).END_RESIZEclears the flag;SETTLE_CROPthen re-expands the crop, recenters, andenforceContainmentrestores the cover invariant.SETTLE_CROPalso self-heals the flag so a caller that forgetsEND_RESIZEstill lands in a coherent state.Behavior is gated to freeform crops — fixed aspect-ratio presets are untouched.
Tests
core/test/sub-unit-zoom.tscovers the sub-unit regime: flag transitions, sub-unit zoom throughSET_ZOOMandenforceContainment, settle self-heal, zoom-back-to-≥1, and camera round-trip atzoom=0.5.react/hooks/test/resize-zoom-out.tsexercises the full dispatch chain through the state hook.preview-export-parity.tssuite is deliberately untouched and still green — the sub-unit regime is transient and never escapes into committed state.Test plan
Follow-ups (not in this PR)
createCamera->getImageFitdelegation refactor.