Revisions Slider: Add aria-valuetext for screen reader accessibility#77549
Open
R1shabh-Gupta wants to merge 1 commit intoWordPress:trunkfrom
Open
Revisions Slider: Add aria-valuetext for screen reader accessibility#77549R1shabh-Gupta wants to merge 1 commit intoWordPress:trunkfrom
R1shabh-Gupta wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #77530
Adds
aria-valuetextto the revisions slider so screen readers announce a meaningful string instead of a bare numeric index.Why?
The revisions slider uses a 0-based index as its value. Screen readers would announce "3" with no context, giving users no useful information about which revision they're on.
How?
Computes a human-readable string from the currently selected revision, e.g. "Revision 3 of 7: January 15, 2025 at 2:30 pm" and passes it as
aria-valuetexton theRangeControl.Testing Instructions
<input type="range">should have anaria-valuetextattribute.aria-valuetextupdates to reflect the newly selected revision's number and date.Testing Instructions for Keyboard
Cmd+F5).Screenshots or screencast
Before
Before-77530.mp4
After
After-77530.mp4
Use of AI Tools
I used Claude Code to review the code.