DataForm: Render field description as help text in the array control#77554
Open
ntsekouras wants to merge 1 commit intotrunkfrom
Open
DataForm: Render field description as help text in the array control#77554ntsekouras wants to merge 1 commit intotrunkfrom
description as help text in the array control#77554ntsekouras wants to merge 1 commit intotrunkfrom
Conversation
ntsekouras
added
[Type] Enhancement
|
Size Change: +56 B (0%) Total Size: 7.76 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in ece239d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24773825229
|
tyxla
reviewed
Apr 22, 2026
| value={ arrayValueAsElements } | ||
| onChange={ onChangeControl } | ||
| placeholder={ placeholder } | ||
| help={ description } |
Member
There was a problem hiding this comment.
This makes sense from the perspective of this PR.
I'm just not sure how reasonable it is to introduce a help prop when we already have __experimentalShowHowTo that handles another type of "help" description. I feel like those two props should work together, and not ignore each other.
Something to discuss in the other PR of course
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
|
Marking as "blocked" for now until #77552 lands |
tyxla
added
the
[Status] Blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR builds up upon the work of: #77552.
It can be tested properly when the above PR is merged and allows the DataForm
arraycontrol to use thefield'sdescription as ahelptext, similarly to the other controls we have.Testing Instructions (after merging
#77552)npm run storybook:dev)?path=/story/dataviews-fieldtypes--array-componenthelptext being rendered