Theme: Increase stroke1 contrast target to 2.9#77599
Draft
jameskoster wants to merge 1 commit intotrunkfrom
Draft
Theme: Increase stroke1 contrast target to 2.9#77599jameskoster wants to merge 1 commit intotrunkfrom
jameskoster wants to merge 1 commit intotrunkfrom
Conversation
|
Size Change: -41 B (0%) Total Size: 7.76 MB 📦 View Changed
ℹ️ View Unchanged
|
Bump the contrast target for `stroke1` from 2.6 to 2.9 so that, on the default scale, it sits between `gray100` and `gray200`. The increased headroom gives surface boundaries more visible separation against neighbouring fills. Regenerates the prebuilt outputs (CSS, JS fallbacks, color.json, default-ramps, snapshot). Affects every consumer of @wordpress/theme. Made-with: Cursor
jameskoster
force-pushed
the
update/theme-stroke1-contrast
branch
from
7f8b454 to
5e36e2a
Compare
Contributor
|
@jameskoster just to understand, can you share an example of where this change comes in handy? |
|
Flaky tests detected in 5e36e2a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24827250466
|
Contributor
Author
|
Yes, will do when I circle back and make the PR ready for review. The TLDR is that without this change the strokes between rows in DataViews (Table and List layouts) are a bit too strong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #75204, separating
DataViewsandThemeconcerns.Bump the contrast target for
stroke1from 2.6 to 2.9 so that, on the default scale, it sits betweengray100andgray200. The increased headroom gives surface boundaries more visible separation against neighbouring fills.Regenerates the prebuilt outputs (CSS, JS fallbacks, color.json, default-ramps, snapshot). Affects every consumer of @wordpress/theme.
Made-with: Cursor