Experiment: Improve taxonomies DataViews height#77603
Merged
Conversation
ntsekouras
added
[Type] Experimental
8 tasks
|
Size Change: 0 B Total Size: 7.76 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 7b2ca61. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24831186086
|
tyxla
approved these changes
Apr 23, 2026
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
Nice improvement, thanks. Good to see the footer all the time now 👍
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
reviewed
Apr 23, 2026
| // the sticky footer stays visible. Note: when the wp-admin sidebar | ||
| // (#adminmenu) is taller than the viewport, #wpwrap still grows to | ||
| // fit it, so empty space may appear below DataViews. | ||
| .boot-layout__stage:has(.taxonomies-page) { |
Member
There was a problem hiding this comment.
BTW, what's a good way to make this available to DataViews consistently, without hacks like this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of: #77600
This PR improves
taxonomiesDataViews height so the sticky footer is visible at the bottom of the visible viewport.There are some more nuances to this because there can still be empty space below the DataViews component if the wp-admin sidebar is taller than the viewport. In site editor this is handled by having the sidebar as a separate scrolling container, but trying something like that for the main sidebar is out of scope of this experiment and might be impactful.
Testing instructions