Fix: ensure Save Draft and Publish buttons are disabled during media upload#77622
Fix: ensure Save Draft and Publish buttons are disabled during media upload#77622Ashok-A15 wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @Ashok-A15. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Ashok-A15! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Problem
The "Save Draft" and "Publish" buttons are not consistently disabled during media uploads, which can lead to flaky behavior in editor interactions and failing E2E tests.
Cause
The disabled state logic relied on a complex conditional that did not reliably reflect the post saving lock state (
isPostSavingLocked), especially during media uploads.Solution
Simplified the disabled state logic for both Save Draft and Publish buttons to ensure they are consistently disabled when:
Changes
isButtonDisabledconditionisToggleDisabledconditionTesting
upload-save-lock.spec.js)Result
Fixes flaky behavior and ensures UI correctly reflects upload/save lock state.