Fix: Disable Custom CSS command for non block themes#77685
Merged
t-hamano merged 2 commits intoWordPress:trunkfrom Apr 28, 2026
Merged
Fix: Disable Custom CSS command for non block themes#77685t-hamano merged 2 commits intoWordPress:trunkfrom
t-hamano merged 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
approved these changes
Apr 27, 2026
Contributor
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! For now, this approach seems to be the simplest 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #73408
Hide the "Open Custom CSS" command from the Command Palette when the active theme is not a block theme.
Why?
The "Open Custom CSS" command is currently available when using hybrid themes (themes with
theme.jsonbut not full block themes). However, invoking this command navigates to the Site Editor and results in an error:This happens because custom CSS editing via Global Styles is only supported for block themes. Hybrid themes may expose partial data, which causes the command to appear even though the feature is not actually usable.
This leads to a broken user experience where users can access a command that always fails.
How?
This PR adds an additional guard to the command registration logic:
getCurrentTheme()from thecorestore to determine whether the active theme is a block theme (is_block_theme)isBlockBasedTheme)Testing Instructions
theme.json, but not a block theme)Expected:
Expected:
Screenshots or screencast
Before
custom-css-hybird-theme.mov
After
custom-css-fix.mov
Use of AI Tools
Drafted PR description with assistance from ChatGPT. The implementation and final PR content were reviewed and validated manually.
P.S.
An alternative approach could be to redirect users on hybrid and classic themes to the Customizer’s "Additional CSS" panel instead of hiding the command entirely as in this previous PR(#65155). This would require confirming that the user has permission to edit theme options, which might be approximated in JS via: