Block Manager: Inline z-index values#77759
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| top: ($grid-unit-05 + 1) * -1; | ||
| z-index: z-index(".block-editor-block-manager__disabled-blocks-count"); | ||
| // Keep the sticky disabled block count above the category items. | ||
| z-index: 1; |
There was a problem hiding this comment.
Z-index value dropped from 2 to 1, due to the new stacking context isolation in block-manager.
|
Size Change: +31 B (0%) Total Size: 7.87 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 1abbfc2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25066357049
|
There was a problem hiding this comment.
Same comment re. rebasing + moving to the new "Unreleased" section
There was a problem hiding this comment.
Same re. moving to new Unreleased section
# Conflicts: # packages/base-styles/CHANGELOG.md
What?
Inlines the Block Manager z-index values that were previously defined in the shared
z-index()helper.Why?
These stacking values only describe layering within the Block Manager and block visibility UI. Keeping them local makes the shared z-index map smaller and easier to reserve for cross-component stacking concerns.
How?
Removes the Block Manager entries from
packages/base-styles/_z-index.scssand replaces the correspondingz-index()calls with local values in the Block Manager and block visibility styles.The category groups now use
isolation: isolate, which keeps category title stacking local to each group while allowing the disabled block count to use the same local z-index value and still appear above the category items.Testing Instructions
npm run lint:css -- packages/base-styles/_z-index.scss packages/block-editor/src/components/block-manager/style.scss packages/editor/src/components/block-visibility/style.scss.Screenshots