RTC: Clarify WPBlockSelection type and link to duplicates in other packages.#77862
Open
RTC: Clarify WPBlockSelection type and link to duplicates in other packages.#77862
Conversation
github-actions
Bot
added
[Package] Core data
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
|
@alecgeatches or @maxschmeling would you be willing to review the docblock change and let me know if I’ve misunderstood anything, particularly the part about the intermediate selection states? |
dmsnell
added
[Feature] Real-time Collaboration
dmsnell
force-pushed
the
rtc/explain-wp-selection-dynamics
branch
from
19721df to
58ec519
Compare
Member
Author
|
@copilot there’s a do all of this EXCLUSIVELY in a new PR — DO NOT interact on this PR. it’s important to keep your exploratory work separate. |
Contributor
|
Size Change: 0 B Total Size: 7.87 MB ℹ️ View Unchanged
|
dmsnell
force-pushed
the
rtc/explain-wp-selection-dynamics
branch
2 times, most recently
from
d61e793 to
c67e682
Compare
…ckages. The `WPBlockSelection` type is more complicated than it may seem at face value. This change expands the docblock information on the type and links together the currently-existing duplicates in other packages, which are duplicated to avoid creating circular dependencies. This is prepartory work for #77658, but stands on its own as a clarifying update.
dmsnell
force-pushed
the
rtc/explain-wp-selection-dynamics
branch
from
c67e682 to
11dd3f3
Compare
|
Flaky tests detected in 11dd3f3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25240965441
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
WPBlockSelectiontype is more complicated than it may seem at face value. This change expands the docblock information on the type and links together the currently-existing duplicates in other packages, which are duplicated to avoid creating circular dependencies.This is preparatory work for #77658, but stands on its own as a clarifying update.
Why?
The existing type information is sparse and ambiguous. The RTC copy of the type mentioned and “intermediate selection state” without indicating what that could mean.
Insightful docs lead to better understanding of the code for humans and bots.
How?
This is a comment-only change.
Use of AI Tools
An LLM was used to review the PR which introduced the type in the
core-datapackage, as well as the code that was changed, to investigate intermediate selection states.