Media Upload Modal: Fix pagination and search#77872
Merged
andrewserong merged 2 commits intotrunkfrom May 1, 2026
Merged
Conversation
andrewserong
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +88 B (0%) Total Size: 7.87 MB 📦 View Changed
ℹ️ View Unchanged
|
ramonjd
approved these changes
May 1, 2026
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
LGTM
I had a question about state persistence but since this PR fixes a pretty nasty bug, it's a good start. Thanks!
Before
Kapture.2026-05-01.at.15.02.21.mp4
After
Kapture.2026-05-01.at.15.03.18.mp4
| slug: 'media-modal', | ||
| defaultView, | ||
| queryParams, | ||
| onChangeQueryParams: setQueryParams, |
Member
There was a problem hiding this comment.
One thing I noticed is that the params persist. So when I reopen the modal with a search or pagination state, that's the first view I see and I have to clear the search/return to the first page if I want to see the start of my lib.
Is that intentional?
Contributor
Author
There was a problem hiding this comment.
Oh, good catch! It's a quick fix, so I'll update it to clear out when the modal closes, and add a test.
Contributor
Author
There was a problem hiding this comment.
Fixed in: f882fe9
(I went with a useEffect instead of in handleModalClose as I imagine we want to clear this out both when the modal is closed and when an item is selected and then the modal closes)
|
Flaky tests detected in f882fe9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25203434575
|
Contributor
Author
|
Thanks for the quick review on this one! 🙇 |
andrewserong
added
the
Backport to Gutenberg RC
Member
|
I just cherry-picked this PR to the release/23.1 branch to get it included in the next release: 892fef0 |
tyxla
pushed a commit
that referenced
this pull request
May 6, 2026
* Media Upload Modal experiment: Fix pagination * Set query params back to defaults when closing the modal Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
tyxla
removed
the
Backport to Gutenberg RC
Contributor
Author
|
Thanks Marin! 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follows:
In the media modal experiment, fix pagination and search. In #77288 we added view persistence, but seemed to have broken pagination and search in the process.
The reason is that
useViewexpects to handlequeryParams(and specificallypageandsearch) separately so that they're not included with the persistent view config. Since we weren't passing inqueryParams, the values were being stripped, which meant that the Next / Prev buttons, etc weren't working in the modal.How?
useViewalong with a callback setter.Testing Instructions
Enable the media upload modal experiment:
Screenshots or screencast
This should work:
2026-05-01.14.47.03.mp4
Use of AI Tools
Codex and Claude Code to verify Codex's fix and tests