Edit Post: Fix suppressed errors in Layout component#77940
Merged
Conversation
Mamaduka
added
[Type] Code Quality
Mamaduka
requested review from
stokesman and
t-hamano
and removed request for
stokesman
Mamaduka
commented
May 5, 2026
Comment on lines
+198
to
+201
| const getAriaValueNow = ( height ) => | ||
| Math.round( ( ( height - min ) / ( max - min ) ) * 100 ); | ||
| const persistIsOpen = ( to = ! isOpen ) => | ||
| setPreference( 'core/edit-post', 'metaBoxesMainIsOpen', to ); |
Member
Author
There was a problem hiding this comment.
Error: Methods can't be used before their declaration.
| { ...navigateRegionsProps } | ||
| ref={ navigateRegionsProps.ref } | ||
| > | ||
| <div { ...navigateRegionsProps }> |
Member
Author
There was a problem hiding this comment.
Error: A false position for calling ref during render. The navigateRegionsProps only contains three values, so we can just use destruction. I couldn't find a reason why this pattern was used in #63611.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -19 B (0%) Total Size: 7.91 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in a8557b4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25367534811
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
PR fixes a couple of suppressed errors after the recent React ESLint rule update. I was just in the area and decided to push the fix.
Testing Instructions
CI checks are passing.
Use of AI Tools
None.