Fix flaky Menu space key unit test#77972
Merged
Merged
Conversation
|
Size Change: 0 B Total Size: 7.94 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 7ad3ada. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25392311640
|
retrofox
approved these changes
May 5, 2026
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
|
Not 100% sure if this will work, but let's see 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes a flaky
Menuunit test by avoiding duplicate coverage of disabled item focus behavior in the Space-key trigger test.Why?
The recent CI failures all had the same shape: after pressing Space on the menu trigger, the menu opened but focus stayed on the menu container instead of moving to the disabled first menu item. The ArrowDown test already covers focusing disabled-but-accessible menu items, so the Space-key test can focus on whether Space opens the menu and moves focus to the first normal item.
How?
Updates the Space-key test fixture so its first menu item is not disabled, and removes the disabled-item-specific test comment from that case.
Testing Instructions
npm run test:unit packages/components/src/menu/test/index.tsx -- --runInBand.