Suggest mode 6c: Capture and apply block-move suggestions (mechanism)#77978
Open
adamsilverstein wants to merge 4 commits intosuggest-mode-6b-insert-uifrom
Open
Suggest mode 6c: Capture and apply block-move suggestions (mechanism)#77978adamsilverstein wants to merge 4 commits intosuggest-mode-6b-insert-uifrom
adamsilverstein wants to merge 4 commits intosuggest-mode-6b-insert-uifrom
Conversation
Moves in Suggest mode now flow through the apply-and-tag pipeline: the block stays at its new position, the metadata.suggestion = pending-move marker carries the from-parent + from-anchor + from- index, and auto-save persists a block-move operation. The detection heuristic combines two signals: any block whose parent changed is a cross-parent move; within the same parent, blocks NOT in the LCS of old vs new sibling order are reordered moves. The LCS step prevents tagging blocks whose index just shifted as a side-effect of another block moving past them — moving B from index 1 to 3 in [A,B,C,D] tags only B, not the C+D that filled the gap. Apply clears the marker (the block is already at its proposed location). Reject clears the marker and dispatches moveBlockToPosition to revert to the from-parent + from-index. Both paths run with bypass so the interceptor doesn't fight them. Refs #77434.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced May 5, 2026
adamsilverstein
added
[Feature] Notes
|
Size Change: +588 B (+0.01%) Total Size: 7.92 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 6f205be. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25407196070
|
…suggest-mode-6c-move-mechanism # Conflicts: # packages/editor/src/components/suggestion-mode/provider.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the data-layer mechanism for block-move suggestions (#77434, task 6c). In Suggest mode a moved block stays at its new position but is tagged with
metadata.suggestion = { type: 'pending-move', fromAnchorClientId, fromParentClientId, fromIndex }. Auto-save persists as ablock-moveop; Apply clears the marker; Reject runsmoveBlockToPositionto revert.Visual treatment lands in the next PR (#77979).
How
Move detection uses two signals:
[A,B,C,D]tags only B.Testing
Stack
Refs #77434, #73411.