Experiment: add first basic user post types e2e tests and update taxonomy tests#77998
Merged
Conversation
ntsekouras
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 7.95 MB ℹ️ View Unchanged
|
Mamaduka
reviewed
May 6, 2026
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
A pass by review for now.
- Visit utils can be inlined, IMO, there's not much gain in single-line utils.
- It's good practice to e2e test UI and the results the user will see, instead of testing REST API responses. If there are no success/failure notices, then UI should be updated first.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 07bb387. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25442844862
|
Contributor
Author
I briefly considered that and was eh.. it's okay. Since you thought about it too, I'll update 😄
I get your point and I thought about that in taxonomies e2e tests (which are the base for these tests). My thinking for these basic tests was to test the UI for create/edit and activate/deactivate and verify through REST that the registration happened as expected. In my mind verifying via REST was the cheapest assertion that the type was actually registered, because having a properly registered taxonomy/post type would ensure any UI (menu items, etc..) to exist, which live in different flows. That said. I'll update that too. |
Member
Sure, but what happens when REST API functions as expected, but the UI contract regresses or breaks? We'll get false positives in the tests. |
ntsekouras
changed the title
t-hamano
added
the
Content types (experimental)
tyxla
approved these changes
May 6, 2026
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
This is looking good from my perspective.
I've added a few nits and suggestions, nothing critical/blocking.
talldan
pushed a commit
that referenced
this pull request
May 8, 2026
…nomy tests (#77998) Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of: #77600
This PR adds some first basic e2e tests for the user post types experiment, mirroring the ones for taxonomies.