Fix: Show collaborators with top toolbar is active#78049
Merged
alecgeatches merged 4 commits intoMay 18, 2026
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
alecgeatches
approved these changes
May 18, 2026
Contributor
alecgeatches
left a comment
There was a problem hiding this comment.
This looks great! Thank you for the fix.
Contributor
|
There was a performance test failure from before, I merged trunk to rerun. This PR should auto-merge if tests pass. |
Contributor
|
Successfully merged. Thank you @DarkMatter-999! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #76599
Makes the collaborators presence list visible in the header when Top Toolbar view is enabled and a block is selected.
Why?
When Top Toolbar view is enabled and a block is selected, the collaborators presence component was not being rendered in the header, making it unclear to users that there are other active collaborators on the post. This is an important piece of information for collaborative editing workflows.
This is an initial implementation to address the visibility issue. The design and UI placement may be refined in future iterations based on feedback.
How?
The fix involves two changes:
packages/editor/src/components/header/index.js): Added a conditional to renderCollaboratorsPresencein the settings area when there is no center content (!hasCenter) and the viewport is wide enough (!isTooNarrowForDocumentBar). This ensures the collaborators list is visible regardless of whether a block is selected.packages/editor/src/components/collaborators-presence/styles/collaborators-presence.scss): Moved themargin-rightstyle from the global.editor-collaborators-presenceclass to a more specific selector (.editor-header__center .editor-collaborators-presence). This ensures proper spacing when the component appears in the center, while allowing the parent settings area'sgapproperty to handle spacing when rendered in the settings area.The two render locations are mutually exclusive due to the conditional logic, preventing any duplication.
Testing Instructions
Screenshots or screencast
Before
show-collaborators-top-toolbar.mov
After
show-collaborators-top-toolbar-fix.mov
PS- We can also have this alternate style for the collaborator presence when top bar is active to better match with the overall settings UI without the background.
Use of AI Tools
Used Github Copilot(Claude Sonnet 4.6) for initial PR review and description.