Fix flaky 'publish panel' e2e test#78082
Merged
Merged
Conversation
Mamaduka
added
the
[Type] Automated Testing
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 7.92 MB ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
fix/publish-panel-flaky-e2e-test
branch
from
187193a to
b6d2951
Compare
|
Flaky tests detected in b6d2951. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25537829697
|
Mamaduka
force-pushed
the
fix/publish-panel-flaky-e2e-test
branch
from
b6d2951 to
5693621
Compare
Mamaduka
commented
May 8, 2026
| const cancelButton = page | ||
| .getByRole( 'region', { name: 'Editor publish' } ) | ||
| .getByRole( 'button', { name: 'Cancel' } ); | ||
| await expect( cancelButton ).toBeEnabled(); |
Member
Author
There was a problem hiding this comment.
This is the actual flaky e2e test fix.
Member
|
@Mamaduka I was also looking at this in the last few days, and also noticed that To trigger My findings described in https://github.com/WordPress/gutenberg/pull/77893/changes#r3217213285 indicate that there is a slide-in animation in progress when the test tries to click "Cancel". On a moving button. Very strange, as animations should be disabled with |
Member
Author
|
Thanks for additional info, @jsnajdr! I’ve not even considered animations because of that global plugin. This seem to reduce flakiness of the test, but that might be due extra check just giving animations enough time to finish. There’s no harm in this change, IMO. |
Member
I agree, there's no harm checking if the button is enabled. But #77721 was automatically reopened just 6 hours after closing. I'm not sure if this can be caused by a PR branch that is still based on an unfixed |
Member
|
Reported a Playwright bug here: microsoft/playwright#40772 Not sure if it's really the cause of this flaky test, but definitely a bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #77721.
PR fixes flaky
should move focus back to the Publish panel toggle button when cancelinge2e test. Ensure theCancelbutton is enabled before clicking on it.Cancel button uses
disabled={ isSavingNonPostEntityChanges } + accessibleWhenDisabled. When both are true, the Button rendersaria-disabledand swallows clicks viastopPropagation/preventDefault, but Playwright still sees it as interactable. On CI, transient non-post entity saves (e.g., preferences) can flipdisabledto true right whenpage.click('… Cancel')fires; the click dispatches, butonClosenever runs, the panel stays open, and the focus assertion fails.Awaiting
toBeEnabled()(which treatsaria-disabledas disabled) prevents the button's click from being actionable.I've also migrated locators to use
getByRole, which fixes a couple of ESLint warnings in the file.How?
Testing Instructions
CI checks should be green.