Experiment: Content types reuse some commone utils#78091
Merged
Conversation
ntsekouras
added
[Type] Experimental
|
Size Change: -321 B (0%) Total Size: 7.92 MB 📦 View Changed
ℹ️ View Unchanged
|
tyxla
approved these changes
May 8, 2026
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
This is looking good to me. Tests well too.
I actually like how some of the consolidation already solved some of the inconsistencies we had (checkboxes => toggles for example).
Suggested a few things to potentially address, but nothing blocking.
🚀
| pluralLabelField, | ||
| singularLabelField, | ||
| slugField, | ||
| ] as Field< PostTypeFormData >[], |
Member
There was a problem hiding this comment.
Why the casting when we could use the generic useMemo type above?
Contributor
Author
There was a problem hiding this comment.
There are nuances due to the Field<ContentType> fields we share and DataForms. Similar case is the media-utils fields (Field< RestAttachment >). I'll keep it for now but will look closer if we can handle this differently.
| hideLabelFromVision, | ||
| markWhenOptional, | ||
| validity, | ||
| }: DataFormControlProps< any > ) { |
Member
There was a problem hiding this comment.
Would have been nice to limit any to ContentType
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 2c8849e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25554159025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Since #78059 we have a single package for content types.
This part adds some shared utils between the two. There are more to consolidate, but let's iterate.