Open
Conversation
Complement the sync package exclusion from Core builds (#78081) by disabling the remaining public RTC APIs at their entry points. These APIs are already shipped publicly, so they cannot be made private; gate them on IS_GUTENBERG_PLUGIN instead so they no-op in Core builds: - getSyncConnectionStatus / setSyncConnectionStatus (core store) - SelectionType / SelectionDirection enums (wp.coreData) - isCollaborationEnabledForCurrentPost (core/editor store) Also gate the CollaboratorsOverlay mount in EditorInterface on IS_GUTENBERG_PLUGIN to prevent the overlay hooks from crashing on the now-undefined SelectionType in Core builds. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
[Package] Core data
t-hamano
added
[Feature] Real-time Collaboration
|
Size Change: +13 B (0%) Total Size: 7.92 MB 📦 View Changed
ℹ️ View Unchanged
|
t-hamano
added
the
Backport to WP 7.0 Beta/RC
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
changed the title
Member
|
Can we make this private? What's the point of shipping public APIs if they don't work? P.S. I think some of these new actions/selects should've been private from the start. |
Contributor
Author
|
I personally wanted to avoid making this private again, as it has already been published in the Gutenberg plugin. |
Member
That's fine. IIRC, APIs are really public when they ship in core. At least that's how I remember this approach. |
Member
|
Worth noting that the sync packages is already being hidden in #78085 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to:
See: https://wordpress.slack.com/archives/C07NVJ51X6K/p1778229071236919?thread_ts=1778216739.261239&cid=C07NVJ51X6K
What?
This PR is part of the effort to disable RTC in the 7.0 release and ensures that public APIs are not shipped to core.
How?
Check
IS_GUTENBERG_PLUGINand prevent the following APIs from being publicly exposed.wp.data.select( 'core' ).getSyncConnectionStatus()wp.data.dispatch( 'core' ).setSyncConnectionStatus( ... )wp.coreData.SelectionTypewp.coreData.SelectionDirectionwp.data.select( 'core/editor' ).isCollaborationEnabledForCurrentPost()This PR is a minimal approach to prevent unintended API exposure. We may need follow-ups to prevent unnecessary subscriptions or side effects.
Testing Instructions
IS_GUTENBERG_PLUGIN=false npm run buildUse of AI Tools
Developed with assistance from Claude (Anthropic) for code analysis and drafting.