Fix: Guard require_once calls in generated PHP files against deployment race conditions#78110
Merged
Conversation
|
Size Change: 0 B Total Size: 7.92 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
file_exists()guards aroundrequire/require_oncecalls in two auto-generated build files to prevent fatal errors during rolling deployments.Why?
During a rolling deployment, individual files can become available at different times. If
pages.phpormodules.phpis loaded before their dependencies (pages/*/page.php,pages/*/page-wp-admin.php, orconstants.php) have finished deploying, PHP throws a fatal error.How?
packages/wp-build/lib/build.mjs: Updates thepageIncludesgenerator to collect all page file paths into a flat array and iterate over them with a foreach loop containing a singlefile_exists()guard, sobuild/pages.phpskips any page files that haven't arrived yet.packages/wp-build/templates/module-registration.php.template: Guards therequire __DIR__ . '/constants.php'call with afile_exists()check and early return, consistent with the existing guard already in place formodules/registry.php.Testing Instructions
npm run build.build/pages.phpand verify the page file includes use aforeachloop over an array of paths, with each file loaded only iffile_exists()returns true.build/modules.phpand verifyconstants.phpis loaded via afile_exists()guard beforerequire.Use of AI Tools
This PR was created with the assistance of Claude Code (claude.ai/code). All changes were reviewed and verified manually.