Classic Block: Use onReplace prop for migration actions#78113
Merged
Conversation
Mamaduka
added
[Type] Code Quality
|
Size Change: -86 B (0%) Total Size: 7.92 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 22371b0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25595364299
|
tyxla
approved these changes
May 9, 2026
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
Nice simplification, thanks! 👍
I've also tested undo/redo behavior in addition to the testing instructions; everything works as expected.
🚀
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
A small follow-up to #78090.
Replaces direct
replaceBlocksdispatch inConvertToBlocksButtonandMigrationNoticewith theonReplaceprop already provided to the block edit. Also drops the redundantserialize( createBlock( 'core/freeform', { content } ) )round-trip, freeform's serializer is identity forcontent.Extracted from my ongoing work, it's an atomic change and better handled that way.
Testing Instructions
Testing Instructions for Keyboard
Same.
Use of AI Tools
None.