i18n: add context to breadcrumbs area label#78134
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I think it would be better to use this instead - - 'aria-label' => _x( 'Breadcrumbs', 'area label' ),
+ 'aria-label' => _x( 'Breadcrumbs', 'breadcrumb navigation aria-label' )
)
);I feel 'aria label' is too generic. A translator encountering it later won't immediately understand this is a screen reader navigation landmark, so I think it is better to make itake it self-documenting. |
|
@himanshupathak95, I think context needs to be short, original string + content should give you the same info as your suggested change. The place where the attribute string is applied isn't important.
|
related to: #78133
can't find the third one.