Skip to content

i18n: add context to breadcrumbs area label#78134

Open
timse201 wants to merge 3 commits into
WordPress:trunkfrom
timse201:patch-1
Open

i18n: add context to breadcrumbs area label#78134
timse201 wants to merge 3 commits into
WordPress:trunkfrom
timse201:patch-1

Conversation

@timse201
Copy link
Copy Markdown
Contributor

related to: #78133

can't find the third one.

@github-actions github-actions Bot added the [Package] Block library /packages/block-library label May 10, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 10, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: timse201 <timse201@git.wordpress.org>
Co-authored-by: himanshupathak95 <abcd95@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added the Internationalization (i18n) Issues or PRs related to internationalization efforts label May 11, 2026
@t-hamano t-hamano linked an issue May 11, 2026 that may be closed by this pull request
6 tasks
@himanshupathak95
Copy link
Copy Markdown
Contributor

I think it would be better to use this instead -

-			'aria-label' => _x( 'Breadcrumbs', 'area label' ),
+			'aria-label' => _x( 'Breadcrumbs', 'breadcrumb navigation aria-label' )
 		)
 	);

I feel 'aria label' is too generic. A translator encountering it later won't immediately understand this is a screen reader navigation landmark, so I think it is better to make itake it self-documenting.

@Mamaduka
Copy link
Copy Markdown
Member

@himanshupathak95, I think context needs to be short, original string + content should give you the same info as your suggested change. The place where the attribute string is applied isn't important.

can't find the third one.

admin-ui package is shared between routes, but it's bundled, so it can create multiple entries.

@Mamaduka Mamaduka added the [Type] Enhancement A suggestion for improvement. label May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i18n: context for breadcrumbs area label

4 participants