Skip to content

Fonts: Move admin menu compat from experimental to wordpress-7.0#78227

Merged
t-hamano merged 1 commit into
trunkfrom
fonts-wp-70-compat
May 13, 2026
Merged

Fonts: Move admin menu compat from experimental to wordpress-7.0#78227
t-hamano merged 1 commit into
trunkfrom
fonts-wp-70-compat

Conversation

@t-hamano
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano commented May 13, 2026 •
edited
Loading

What?

Move the Fonts admin menu compatibility shim from lib/experimental/fonts/load.php to lib/compat/wordpress-7.0/fonts.php.

Why?

The dedicated Font Library page will be released in 7.0. To ensure that redundant code in Gutenberg is removed in the future, it would be best to move it to the appropriate directory.

Testing Instructions

Access "Appearance" → "Fonts" and confirm the Font Library page loads.

Use of AI Tools

This PR was authored with assistance from Claude Code for the file move and commit message drafting. The author reviewed and verified all changes.

@t-hamano t-hamano self-assigned this May 13, 2026
@t-hamano t-hamano added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Code Quality Issues or PRs that relate to code quality labels May 13, 2026
@t-hamano t-hamano requested review from Mamaduka and youknowriad May 13, 2026 08:00
@t-hamano @claude
Fonts: Move admin menu compat from experimental to wordpress-7.0
3e5c38f 
The Fonts admin menu registration targets WordPress 7.0, so relocate it
into lib/compat/wordpress-7.0/ to follow the version-specific compat
layout instead of leaving it under experimental/.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@t-hamano t-hamano force-pushed the fonts-wp-70-compat branch from 217fa4d to 3e5c38f Compare May 13, 2026 08:00
@t-hamano t-hamano added the No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core label May 13, 2026
@t-hamano t-hamano marked this pull request as ready for review May 13, 2026 08:00
@t-hamano t-hamano requested a review from spacedmonkey as a code owner May 13, 2026 08:00
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Mamaduka
Mamaduka approved these changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @t-hamano!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

Flaky tests detected in 3e5c38f.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25786318201
📝 Reported issues:

@t-hamano t-hamano merged commit 7936ff9 into trunk May 13, 2026
48 of 49 checks passed
@t-hamano t-hamano deleted the fonts-wp-70-compat branch May 13, 2026 09:00
@github-actions github-actions Bot added this to the Gutenberg 23.2 milestone May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@youknowriad youknowriad Awaiting requested review from youknowriad

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@t-hamano t-hamano

Labels

Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Milestone

Gutenberg 23.2

Development

Successfully merging this pull request may close these issues.

2 participants

@t-hamano @Mamaduka