Suggest mode: Surface Apply/Reject in the collaboration sidebar#78353
Open
adamsilverstein wants to merge 1 commit into
Open
Suggest mode: Surface Apply/Reject in the collaboration sidebar#78353adamsilverstein wants to merge 1 commit into
adamsilverstein wants to merge 1 commit into
Conversation
Wire icon-only Apply / Reject controls into the note header and a shared useSuggestionDecision hook into the note body so the staleness dialog and resolution state stay consistent. Notes carrying a _wp_suggestion payload now render the SuggestionSummary in the thread, and block-notes and editor-intent-switcher e2e specs cover the new sidebar UI.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
One of three replacement PRs for the now-closed #77407. This slice wires Apply / Reject sidebar UI on top of the summary + attribute-conflict work from #78352.
Tracking issue: #73411.
What's in this PR
Collaboration sidebar
useSuggestionDecisionhook insuggestion-actions.js— A single source of truth for Apply / Reject behavior. Both the note header (icon buttons) and the note body (resolution state, staleness dialog) read from the same hook, so their behavior cannot diverge.check,closeSmallicons from@wordpress/icons).SuggestionSummaryplus the staleness confirmation dialog whenhasAttributeConflictreturns true.utils.js— helpers shared between note components for reading the suggestion-related metadata.Tests
test/utils.jsextended for the new helpers.block-notes.spec.js(new spec covering Apply / Reject flows) andeditor-intent-switcher.spec.js(snackbar assertions).Test plan
Manual:
hasAttributeConflict).Replaces part of #77407.
🗺️ PR Stack Navigation
_wp_suggestionmeta, provider, sidebar actions📋 Tracking issue: #73411