Tabs, TabPanel: Align styles with wp-ui#78418
Merged
Merged
Conversation
mirka
changed the title
|
Size Change: +733 B (+0.01%) Total Size: 7.97 MB 📦 View Changed
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in b3993f8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/26060561923
|
ciampo
approved these changes
May 19, 2026
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
LGTM 🚀
also cc @jameskoster for any specific design feedback?
Contributor
There was a problem hiding this comment.
I assume that we want to keep COLORS.ui.textDisabled (since we're still leaning into Emotion and shared JS variables), even if there's a small drift compared to @wordpress/ui (#949494 vs #8d8d8d)
The same would apply for the gray[ '700' ] and gray[ '100' ] variables.
To be clear: I like how it is currently in this PR and it's fine for me to ship it as-is
Member
Author
There was a problem hiding this comment.
Right. I thought about converting to CSS modules first so we can use the exact tokens, but given that this is a private component, we can perhaps just delete all the code once all the instances are migrated.
Contributor
|
Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #76135
Updates the selected tab colors and indicator styles in
@wordpress/componentsTabsandTabPanelto better match@wordpress/uiTabs.Why?
So it's less jarring for users during the transition phase with mixed usage of the components.
How?
Tabsindicators from accent/brand styling to neutral colors.TabPaneltab text, selected indicator, vertical selected state, and focus ring styles to use the corresponding design system tokens.TabPanelstyles with design system tokens.Testing Instructions
Components/TabPanelandComponents/Tabs.Screenshots or screencast