UI Button: Fix disabled cursor style#78479
Merged
Merged
Conversation
|
Size Change: +2 B (0%) Total Size: 7.98 MB 📦 View Changed
ℹ️ View Unchanged
|
mirka
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aduth
approved these changes
May 20, 2026
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
LGTM 👍 Tested combinations of cursor options and disabled states in local Storybook and works as expected.
I'm a bit surprised we missed this, but I guess it might have slipped unnoticed when we changed the default button cursor from default to pointer? i.e. Before then we didn't need to explicitly handle disabled styles.
Member
Author
Exactly! We already caught a few of these after that change 😄 |
|
Flaky tests detected in 54ebb58. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/26186152990
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes the
@wordpress/uiButtoncursor style so disabled buttons do not receive the interactive control cursor.Why?
Disabled buttons should not visually suggest that they are interactive. The base button styles were applying
--wpds-cursor-controlregardless of the disabled state.How?
Only applies the control cursor when the button does not have
data-disabled. The existing link-specific cursor styling remains unchanged.Testing Instructions
Buttoncomponents.