Dashboard: forbid non-module stylesheets in experimental, new widgets#78496
Merged
Conversation
simison
added
[Type] Build Tooling
simison
force-pushed
the
update/dashboard-widgets-lint
branch
from
ba56e07 to
47293d6
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 7.98 MB ℹ️ View Unchanged
|
simison
commented
May 21, 2026
|
Flaky tests detected in 6220b3f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/26216161563
|
simison
force-pushed
the
update/dashboard-widgets-lint
branch
from
47293d6 to
6220b3f
Compare
retrofox
approved these changes
May 21, 2026
Contributor
retrofox
left a comment
retrofox
left a comment
There was a problem hiding this comment.
LGTM. Minor, but useful 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #77616
Adds
widgets/*to Eslint setup for@wordpress/no-non-module-stylesheet-importsrule:Not allowed:
import './style.scss'import styles from './style.css'(non module)Allowed:
import styles from './foo.module.css'Why?
Restricts to the latest approach to CSS in the Gutenberg repo, now that the folder is still fresh.
How?
Testing Instructions
You can try non-allowed imports in
widgets/hello-worldand se it failnpm run lint:jsTesting Instructions for Keyboard
Screenshots or screencast
Use of AI Tools