Fix flaky e2e test with dataview kbd navigation#78503
Merged
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 7.98 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 1cfcfe0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/26220866253
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64334, a flaky e2e test with up/down keyboard navigation in a dataview. The fix is in spirit very similar to #78063. The problem is that:
deleteAllPagesinglobal-setup.js, leaving the default "Privacy Policy" and "Sample Page" pages created by WordPress install. The starting point of the test is then not always the same. Sometimes there are zero pages, sometimes there are the default two pages. AddingdeleteAllPagesensures that there are always zero pages at start.The locator for "Sample Page" then fails because of an ambiguous result.
This PR adds
deleteAllPagesto global setup, and changes the name of the two pages created by the test suite, so that there is never any name confusion. The #78063 fix for homepage settings did a similar change from "Sample page" to "Posts page".