Font Library: Fix Update button staying active when changes are reverted#78567
Merged
Conversation
juanfra
added
[Type] Enhancement
|
Size Change: +96 B (0%) Total Size: 8.21 MB 📦 View Changed
ℹ️ View Unchanged
|
t-hamano
reviewed
May 29, 2026
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR!
How about using fast-deep-equal without introducing custom logic? It is also frequently used within the Gutenberg repository.
This can probably be written as follows.
const fontFamiliesHasChanges = ! fastDeepEqual(
globalStyles?.record?.settings?.typography?.fontFamilies,
globalStyles?.editedRecord?.settings?.typography?.fontFamilies
);
Note that the library needs to be added to the @wordpress/global-styles-ui package beforehand.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
|
Thanks for the review @t-hamano 🙌 The purpose of the custom logic there is ordering, to properly compare values. When you toggle a variant off and then back on, it gets appended to the end of the array, so you end up with two arrays that hold the same data but in a different order. Without sorting them first, the comparison could fail as it'd be thinking something changed when it actually didn't. The same for saved data (which is probably ordered in the way the user toggled things). I'm happy to pull in |
t-hamano
approved these changes
Jun 1, 2026
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
When you toggle a variant off and then back on, it gets appended to the end of the array, so you end up with two arrays that hold the same data but in a different order. Without sorting them first, the comparison could fail as it'd be thinking something changed when it actually didn't.
Thank you for explaining in detail! In that case, it seems that the current approach is fine.
Member
Author
|
Thanks Aki! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The "Update" button in the Font Library modal stays enabled after toggling a font variant on and then off again, even though the selection is identical to what was last saved. This makes users think there is something to save when there's not.
Why?
The previous check (
!! globalStyles.edits.settings.typography.fontFamilies) only tested whether an edits entry existed, not whether it differed from what's saved. Once you touch a checkbox, the entry is set and never clears. Even if you go bakc to the to the original selection.How?
Compare the edited
fontFamiliesvalue against the saved one fromglobalStyles.record, not just whether an edits entry exists. AddedgetFontFamiliesKey()to normalize families and faces before comparing, so re-toggling a variant doesn't leave the button enabled just because the order changed. Wrapped the check inuseMemoso it only runs when the edited or saved value actually changes.Testing Instructions
Screenshots or screencast
font-library.mp4