UI Button: Fix pressed disabled styles for neutral minimal#78635
Merged
Conversation
|
Size Change: -8 B (0%) Total Size: 8.13 MB 📦 View Changed
ℹ️ View Unchanged
|
mirka
force-pushed
the
fix/button-pressed-disabled-styles
branch
from
ddd8575 to
be44177
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
Bot
added
[Package] Components
mirka
force-pushed
the
fix/button-pressed-disabled-styles
branch
from
7cd2d8e to
be44177
Compare
github-actions
Bot
removed
[Package] Components
ciampo
approved these changes
May 25, 2026
|
Flaky tests detected in be44177. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/26415616785
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes disabled styling for neutral minimal buttons with
aria-pressed="true".Why?
Pressed neutral minimal buttons use the strong appearance, but disabled styles still pulled from the unpressed weak minimal tokens. That made pressed + disabled buttons look like unpressed disabled buttons.
Testing Instructions
@wordpress/ui.Screenshots or screencast