Change to math.js#78643
Open
mikachan wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds rectangle-area helper utilities to block-editor’s math.js so callers can compute a DOMRect area and compare two rectangles by area.
Changes:
- Add
getRectArea( rect )to compute(right - left) * (bottom - top). - Add
getSmallerRectArea( a, b )to return the smaller of two rectangle areas.
| * @return {number} The smaller area. | ||
| */ | ||
| export function getSmallerRectArea( a, b ) { | ||
| const areaA = a.right - a.left * a.bottom - a.top; |
|
Size Change: 0 B Total Size: 7.98 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Testing out the Copilot instructions in #78584. Do not merge!
Why?
Copilot reads
.github/copilot-instructions.mdfrom the PR's base branch, so the rules in #78584 can't be observed on that PR itself. Opening a PR againstadd/copilot-instructionsas the base is to test out these new rules.How?
Testing Instructions