Conversation
tyxla
added
[Type] Code Quality
github-actions
Bot
added
[Package] Element
github-actions
Bot
added
[Package] Interface
Member
|
🎉 |
tyxla
force-pushed
the
remove/rn
branch
2 times, most recently
from
82d6d2b to
f620c0c
Compare
|
Size Change: 0 B Total Size: 8.18 MB ℹ️ View Unchanged
|
Member
manzoorwanijk
left a comment
manzoorwanijk
left a comment
There was a problem hiding this comment.
I am always in favor of such clean-ups. When the code is no longer used or has been broken for too long without anyone noticing/reporting it, it's best to remove it to reduce the maintenance burden.
Apart from that, RN stuff has been a pain when it comes to dependency management in the repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
I was curious to see what it would look like if we removed all of the React Native work from the codebase.
Here it is.
Why?
Currently, the RN implementation is broken in trunk, and working on it requires working off the latest release branch anyway. There is currently little to no active work on the Gutenberg Mobile project, no work to fix the RN implementation is planned.
How?
Just deleting tons of RN files and dependencies.
Testing Instructions
All should be green.
Testing Instructions for Keyboard
None
Screenshots or screencast
None
Use of AI Tools
Claude Opus 4.7