Shortcode block: Fix editor crash when selecting transform menu#78770
Merged
Conversation
talldan
added
[Type] Bug
|
Size Change: +1 B (0%) Total Size: 8.18 MB 📦 View Changed
ℹ️ View Unchanged
|
Mamaduka
approved these changes
May 28, 2026
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Thanks for catching this, Dan! 🙇
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
If a user inserts a shortcode block and then without typing anything selects the transform menu, it causes an editor crash.
Why?
Some code in the shortcode transform handling tries to execute
text.trim()whentextisundefined. It looks like this is recent, from #77944.How?
Fixed by defaulting the string to an empty param.
Testing Instructions
Expected: The menu opens
In trunk: The editor crashes
Use of AI Tools
None, fixed it the ol' fashioned way