Icons: rename timeToRead to time#78804
Merged
Merged
Conversation
simison
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 8.21 MB ℹ️ View Unchanged
|
Member
Author
|
Noting that best to get this in first and then rebase this one (which is easier): |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
Agree with this. Related: #78808 (comment) |
t-hamano
reviewed
May 29, 2026
|
Flaky tests detected in 6bf5cc7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/26632940183
|
Contributor
|
Maybe something for a separate effort but should we consolidate |
Member
Author
|
Ya, now that they're even more similar visually, should prolly merge. Can be separate PR. |
Contributor
|
Two things:
|
Member
Author
|
Sounds good! Any preference for what time the clock should show? :-) 
They seem to have some other slight differences as well. |
Contributor
|
The two icons are very similar, but it should be noted that the 
Therefore, if the icon name is changed from Personally, I prefer not to consolidate these two icons because they serve different purposes, and simply change |
Member
Author
|
I'll merge this for the weekend, and we can chew on the merging question more next week. The next package release isn't for a while anyway, so this won't have an impact even if we rename → merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Renames "timeToRead" icon to "time".
Why?
At #72240 we added "time to read" icon (alongside word count icon) to support "time to read" feature.
The icon is more generally useful, though, but the name can discourage usage. Typically, if a visual is fitting for some other feature, I'd still be worried the visual gets changed to something else if it's too tied to a specific feature already. "Time" is more generic.
"Clock" could be a more descriptive name, but "Time" seems fitting as more generic and internet image search seems to agree.
If we need an hourglass icon in future, it would make sense to have it called descriptively "hourglass" (rather than have it represent "time").
Note that there is also scheduled icon which is very similar:
Alternatives could be to merge those or rename "scheduled" to "time" and keep "timeToRead".
How?
The icons package is bundled when building with wp-scripts/wp-build, so we don't need to worry about breaking changes and keep exporting old name.
Testing Instructions
Testing Instructions for Keyboard
Use of AI Tools
Yes