Revert React 19 upgrade#78940
Merged
Merged
Conversation
jsnajdr
requested review from
a team,
adamsilverstein,
adamziel,
ajitbohra,
atimmer,
draganescu,
ellatrix,
fabiankaegy,
gigitux,
gziolo,
kevin940726,
nerrad,
ntsekouras,
ntwb,
oandregal,
peterwilsoncc,
ryanwelcher and
talldan
as code owners
jsnajdr
added
Backport to Gutenberg Minor Release
github-actions
Bot
added
[Package] Element
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -15.9 kB (-0.19%) Total Size: 8.19 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 7760704. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/26947690257
|
Member
|
Haven't been this sad for any other reverts 😢 Let's work on the next steps, alongside this revert. Otherwise, I've a feeling we'll never be able to upgrade. |
Member
True.
Yes, lets do it 💪 |
Member
Author
I will be OK in the end, we must now devise some good compat layer for plugins that were compiled and tested against React 18. |
Member
|
Reverts:
Plus some conflict resolutions from changes to |
aduth
reviewed
Jun 4, 2026
Comment on lines
-8
to
+13
| export { | ||
| findDOMNode, | ||
| render, | ||
| hydrate, | ||
| unmountComponentAtNode, | ||
| } from './react-polyfill'; | ||
| // export { | ||
| // findDOMNode, | ||
| // render, | ||
| // hydrate, | ||
| // unmountComponentAtNode, | ||
| // } from './react-polyfill'; |
Member
There was a problem hiding this comment.
Are we intending to keep this commented out vs. removed?
Member
Author
There was a problem hiding this comment.
I'm commenting it out because I expect to re-enable it soon again. It will be for sure part of the React 19 build.
aduth
approved these changes
Jun 4, 2026
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
LGTM 👍
I did:
- A manual line-by-line inspection comparing this pull request to the original
- AI-assisted review of the same and other supporting pull requests
- Looked for new code additions that might be relying on React 19 features (ref as prop, inert, APIs like
use) - Spot check loading the editor, including with popular plugins like Elementor and WooCommerce to ensure no load errors. Elementor onboarding loads successfully.
Member
|
A bummer we need to revert, but thank you for handling this, folks 🙇 |
jsnajdr
added a commit
that referenced
this pull request
Jun 4, 2026
arthur791004
removed
the
Backport to Gutenberg Minor Release
This was referenced Jun 4, 2026
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're running into some serious issues with plugins that bundle
react/jsx-runtimeand produce incompatible elements:$$typeof: Symbol.for('react.element')(legacy) versus$$typeof: Symbol.for('react.transitional.element')(new).Then there is a runtime check that throws when legacy element is encountered: https://react.dev/errors/525
React 19 used to have a feature flag called
renameElementSymbolto enable/disable this behavior, with some patching we might be able to recover it for WordPress/Gutenberg.