Table block: Keep table actions enabled after deleting a row or column#78962
Open
Mayank-Tripathi32 wants to merge 1 commit into
Open
Table block: Keep table actions enabled after deleting a row or column#78962Mayank-Tripathi32 wants to merge 1 commit into
Mayank-Tripathi32 wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #28714 - independent Testing required, Please do not merge.
After deleting a row or column in the Table block, the "Edit table" menu actions (Insert/Delete row/column) became disabled until the user clicked a cell again to refocus. This PR keeps a sensible cell selected after the deletion, so the actions stay usable.
Why?
onDeleteRowandonDeleteColumnwere callingsetSelectedCell()(clearing the selection) and then setting the new attributes. Every item intableControlsusesisDisabled: ! selectedCell, so the whole menu greyed out until focus returned to a cell. The reporter (and several follow-up confirmations across multiple WP/Gutenberg versions) all had to click a cell to perform a second edit.How?
Mirrors the pattern already used by
onInsertRow/onInsertColumn: after mutating the attributes, select a cell that still exists.columnIndex, withrowIndexclamped to the new section length. If the section is empty after the delete, clear the selection.sectionName/rowIndex, withcolumnIndexclamped to the new column count (usinggetFirstRowto read it). If no columns remain, clear.Testing Instructions
E2E coverage is added in
test/e2e/specs/editor/blocks/table.spec.jsas a regression test.Testing Instructions for Keyboard
No keyboard-interaction changes. The same regression test exercises the menu after both row and column deletion.
Ai Usage?