Select tab panel when caret moves into tab#79558
Merged
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -7 B (0%) Total Size: 7.49 MB 📦 View Changed
|
…ractions Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Mamaduka
approved these changes
Jun 26, 2026
SainathPoojary
pushed a commit
to SainathPoojary/gutenberg
that referenced
this pull request
Jun 29, 2026
Co-authored-by: jeryj <jeryj@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates the Tabs block so that moving the caret into a tab's label in the editor activates that tab's panel, matching the existing click behavior.
Why?
In the editor, the active tab panel only switched when you clicked a tab. Moving the caret into a different tab label with the keyboard left the previously selected panel showing — you had to click in the editor to update which panel was visible. This is inconsistent and breaks keyboard-only editing of tabs.
How?
All tab labels live as
RichTextfields inside a singlecore/tab-listblock, so moving the caret between labels with the keyboard never changes the selected block and never fired the existing click/selection handlers that update the active panel.In
tab-list/edit.js:handleTabClicktoselectTabPanel, since it sets the active panel regardless of how it's triggered.onClickhandler with anonFocushandler on each tab button that callsselectTabPanel( index ). React'sonFocusbubbles (viafocusin) from the innerRichTexteditable, so focus landing in a tab label activates the matching panel.selectTabPanelalready no-ops when the target tab is already active and marks the change as non-persistent (kept out of undo history), so the addedonFocusis safe alongside the click path.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Use of AI Tools
I used Claude Code to investigate the cause and draft the change.