Fix stale chromeless query flag in README - #327
Merged
Conversation
The window-system section documented iframe windows loading with `?wp_desktop=1`, but the actual routing flag is `desktop_mode_chromeless=1` (see includes/core/routing.php). Update the README to match. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
|
Good first issue :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Window system — iframe + native section of
README.mddocumented iframe windows loading admin pages with?wp_desktop=1, but that flag doesn't exist in the code. The actual chromeless routing flag isdesktop_mode_chromeless=1.Why
Verified against the source:
includes/core/routing.php:275gates chromeless mode on$_GET['desktop_mode_chromeless'].wp_desktopoccurrence inincludes/is the unrelatedwp_desktop_mode_file_placementsDB key.docs/architecture.mdalso documentsdesktop_mode_chromeless=1, so the README line was simply stale.Docs-only change; no build artifacts affected.
🤖 Generated with Claude Code