Surface core admin notices once in the desktop shell

[mmtr]

What & why

WordPress prints its global admin notices (update failed, recovery mode, "you're using an auto-generated password", force-deactivated plugins, paused plugins/themes) on every admin screen. Because desktop mode renders each screen as its own window, those notices repeat in every open window.

This detaches them inside windows and surfaces each once at the shell level as a dismissible toast, re-derived from WordPress's own state. It builds on the earlier "WordPress update available" work and applies the same pattern to the rest of Core's global notices.

It also adds a small, opt-in allowlist for shared library notices that behave the same way — starting with Action Scheduler's "past-due actions" warning (bundled by WooCommerce and many others). Regular plugin notices are left untouched and still render in-window.

Every notice is a persistent toast with a close (×) button; dismissing one keeps it dismissed. Each toast's action opens the relevant screen as a window.

Testing

You need a site with desktop mode enabled. Trigger a couple of notices via WP-CLI, then load the shell.

1. Trigger two easy ones:
   • wp user meta update <your-login> default_password_nag 1
   • wp option update wp_force_deactivated_plugins '[{"plugin_name":"Test Plugin"}]' --format=json
2. Open the desktop shell. Expected: each notice appears once as a toast in the top-right.
3. Open any window (e.g. Posts, Settings). Expected: the notices do not repeat inside the window.
4. Click a toast's × to dismiss it, then reload the shell. Expected: that toast stays gone; the others remain.
5. Click a toast's action button (e.g. "Change password"). Expected: the correct screen opens as a window, titled by the screen (not the button).
6. Clean up: wp user meta delete <your-login> default_password_nag and wp option delete wp_force_deactivated_plugins.

To also check Action Scheduler, install a plugin that bundles it (e.g. WooCommerce) and create past-due scheduled actions; the "past-due actions" toast appears once and is stripped from windows.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR prevents global WordPress admin notices (Core + a small allowlist of shared library notices like Action Scheduler) from repeating inside every desktop-mode window by suppressing them in chromeless iframes and surfacing them once at the shell level as persistent, dismissible toasts derived from server state.

Changes:

• Add server-side “notice descriptor” builders for Core global notices and allowlisted library notices, expose them on the shell config, and document new filters.
• Suppress the corresponding admin_notices callbacks in chromeless requests so notices don’t re-render per window.
• Add shell-side toast rendering + dismissal persistence, plus PHPUnit/Vitest coverage and a small toast [hidden] styling fix.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/phpunit/tests/pluginNotices.php	Adds PHPUnit coverage for Action Scheduler allowlisted notice + chromeless suppressor behavior.
tests/phpunit/tests/coreNotices.php	Adds PHPUnit coverage for Core notice builders, aggregation/filtering, and chromeless suppression.
src/ui/components/wpd-toast/wpd-toast.test.ts	Adds a regression test ensuring [hidden] buttons are actually hidden in toast styles.
src/ui/components/wpd-toast/wpd-toast.styles.ts	Ensures author styles don’t override the UA [hidden]{display:none} behavior.
src/types.ts	Extends DesktopConfig with coreNotices and pluginNotices descriptor shapes.
src/desktop.ts	Wires notice descriptors into shell boot and opens notice action URLs as windows.
src/core-notices.ts	Implements shell rendering of notice descriptors as persistent, dismissible toasts with local dismissal storage.
src/core-notices.test.ts	Adds Vitest coverage for notice rendering, action wiring, and dismissal key namespacing.
includes/render/assets.php	Adds coreNotices and pluginNotices into the JS boot config payload.
includes/plugin-notices.php	Implements allowlisted library notice descriptors (Action Scheduler) + chromeless detachment.
includes/core/routing.php	Adds chromeless suppression for remaining Core global notices.
includes/core-notices.php	Implements Core global notice descriptor builders + aggregation and filtering.
docs/hooks-reference.md	Documents new desktop_mode_core_notices and desktop_mode_plugin_notices filters.
desktop-mode.php	Loads the new Core/plugin notice PHP modules.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.