Fix illegible text fields inside wpd-modal dialogs - #374
Merged
epeicher merged 1 commit intoJul 20, 2026
Conversation
epeicher
deleted the
deskmod-50-drag-to-upload-to-media-library-css-is-broken
branch
July 20, 2026 08:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Makes text fields inside
<wpd-modal>dialogs legible again. The "Upload to Media Library" drag-and-drop dialog rendered its pre-filled Title / Filename / Alt text values as near-white text on white inputs.Rationale
<wpd-modal>'s dialog surface is dark and re-points the shared kit tokens (--desktop-mode-text,--desktop-mode-border, the muted colors) so slottedwpd-*controls resolve dark-surface colors, but it never re-pointed--desktop-mode-window-bg. That token is the input background for<wpd-text-field>/<wpd-textarea>, so it kept its:rootvalue of#fff(windows are light) while the text inside resolved to the modal's light#f0f0f1— invisible values.Implementation
Added the missing token to the existing dark-token block on the modal
:host:Solid rather than translucent on purpose:
wpd-menuandwpd-multiselectpopovers read the same token and must stay opaque over slotted content. Because the fix is at the modal level, it also repairs every other modal hosting form fields (folder share settings, wallpaperrenderConfigdialogs, the games challenge dialog). The share-settings capability control keeps its own instance-level inline overrides, which still win.The
static helpsummary onWpdModalnow lists-window-bgamong the re-pointed tokens.Testing instructions
npm run test:jsstays green (2051 tests).