v0.9.6: Add busy state and spinner to wpd-button - #379
Merged
Conversation
Improve button accessibility and visual feedback by implementing the missing busy state on the Button component. The button now disables itself, displays an animated spinner, and sets aria-busy when in a busy state. Also adds localStorage mock to test setup for Node 26 compatibility and updates to WordPress 7.0.2.
Collaborator
|
Thank you for your contribution! |
AllTerrainDeveloper
approved these changes
Jul 22, 2026
AllTerrainDeveloper
left a comment
AllTerrainDeveloper
left a comment
Collaborator
There was a problem hiding this comment.
I'm adding myself the box-sizing: border-box to speed up the merge :)
Thank you very much!
Collaborator
|
By the way, you'll appear here :) |
Contributor
Author
|
Thank you for merging the PR and for the mention! Could you please add my WordPress profile as a contributor on the WordPress.org plugin page too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve button accessibility and visual feedback by implementing the missing busy state on the Button component. The button now disables itself, displays an animated spinner, and sets aria-busy when in a busy state. Also adds localStorage mock to test setup for Node 26 compatibility and updates to WordPress 7.0.2.