Fix: Admin bar visibility when fullscreen window is minimized - #384
Merged
AllTerrainDeveloper merged 2 commits intoJul 21, 2026
Merged
Conversation
Two regression tests for updateFullscreenBodyClass(): - minimizing a fullscreen window clears body.desktop-mode-has-fullscreen-window (the admin-bar bug) - the class survives while another visible fullscreen window remains, and drops when the last one minimizes Verified both fail against trunk's window sources. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
AllTerrainDeveloper
approved these changes
Jul 21, 2026
AllTerrainDeveloper
left a comment
AllTerrainDeveloper
left a comment
Collaborator
There was a problem hiding this comment.
Thanks so much for this contribution! It works perfectly. 🙌
The only thing missing was a couple of tests, so I took the liberty of adding two to cover the new behavior. Other than that, everything looks great. Thanks again for your work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #383
Fixes the bug where the WordPress admin bar remains hidden when a fullscreen window is minimized.
Why?
When a window enters fullscreen mode, it adds a global CSS class (
desktop-mode-has-fullscreen-window) to the body to hide the admin bar for an immersive experience. Previously, minimizing this fullscreen window kept the class active because the window retained its underlying fullscreen state, leaving the admin bar inaccessible across the entire desktop.How?
src/window/dom.ts:updateFullscreenBodyClass()to ignore minimized windows (:not(.desktop-mode-window--minimized)). This ensures the body class is removed if the only fullscreen windows are docked.src/window/index.ts:minimize()method to immediately callupdateFullscreenBodyClass()if the window being minimized is in fullscreen mode, instantly updating the admin bar's visibility.Testing Instructions
Screencast
Screen.Recording.2026-07-21.at.8.46.09.PM.mov