fix: show open window indicators for bottom dock tiles - #386
Merged
AllTerrainDeveloper merged 2 commits intoJul 22, 2026
Merged
Conversation
Collaborator
There was a problem hiding this comment.
Went through this today. Nice find on the three root causes, and thanks for the before/after shots, they made it easy to verify. I checked out the branch and ran the full vitest suite (2085 tests), all green, which was my main worry since slugify feeds window ids everywhere. Left a few small comments inline, nothing blocking. Thanks for the contribution!
AllTerrainDeveloper
approved these changes
Jul 22, 2026
Collaborator
|
Just a note, that you are already appearing here: If you have any inconvenience, please tell it to me :) |
Contributor
Author
|
Thank you so much !! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #378
Description
This PR fixes missing open window indicators (active dots, focused pills, and minimized rings) underneath items placed on the bottom dock (such as WooCommerce ,Marketing, or Payments).
Root Causes & Fixes
.desktop-mode-dock__scrollhadoverflow-y: hiddenwith0pxbottom padding. Positioned atbottom: -4px, active indicators were rendered outside the scroll wrapper bounds and completely clipped by the browser.padding-bottom: 6pxandoverflow-y: visibleto the scroll and pinned containers in dock.css, and positioned the indicator atbottom: -3px.wc-admin&path=%2Fmarketing) slugified toadmin-php-page-wc-admin-path-2Fmarketing(with2F), while the opened window URL slugified toadmin-php-page-wc-admin-path-marketing. The resulting base ID mismatch prevented the dock from identifying open windows.decodeURIComponenthandling insideslugify()in utils.ts so encoded and unencoded URLs slugify identically.dock:prefix) carried empty URLs, causing base ID resolution to fail.resolveItemBaseId()in dock.ts to handle promoted desktop icons and added a fallback matcher toupdateActiveStates()checking derived URL IDs and tile IDs.Verification
npm run build:desktopbuilt successfully.npm run typecheckpassed with no errors.npm run lintpassed with no errors.npx vitest run tests/vitest/dock-minimized-indicator.test.tspassed 9/9 tests.Before fix
After fix