fix(dock): improve icon visibility and fix separator height - #39
Conversation
darksns
commented
Apr 29, 2026
- Force monochrome white palette on plugin SVG icons that ship with hardcoded fill attributes, so they match the dashicons look
- Add hover opacity transition on dock icons (0.7 → 1)
- Fix horizontal separator height: was 60% (collapsing against the taskbar pill), now fixed 28px to match the dock tile glyph area
- Bump dock border alpha from 0.08 to 0.2 for better visibility
- Force monochrome white palette on plugin SVG icons that ship with hardcoded fill attributes, so they match the dashicons look - Add hover opacity transition on dock icons (0.7 → 1) - Fix horizontal separator height: was 60% (collapsing against the taskbar pill), now fixed 28px to match the dock tile glyph area - Bump dock border alpha from 0.08 to 0.2 for better visibility Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Hi, I see!
I'll work on it so it looks good in both situations. In the screenshot, I imagine it's a clean WordPress installation. In my installation, where there are also third-party plugin icons to the left of the separator, the missing separator was noticeable and there was a visible empty space.
I'll be back shortly with an update.
Thank you
Il 30 apr 2026, 19:38 +0200, Daniel López Sánchez (prismiwi2015) ***@***.***> ha scritto:
… AllTerrainDeveloper left a comment (WordPress/openstation#39)
Thank you for your first contribution!
BEFORE
AFTER
image.png (view on web)
image.png (view on web)
There seems to be kind of a regression in the taskbar, a new "separator" appeared. Would you mind to refine it and we ship it!
Again, thank you!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Address review feedback on PR WordPress#39: on a clean WordPress install where the taskbar (or dock) has no menu items but at least one system item is registered, the system separator was rendered as a stray hairline with nothing to divide above/before it. The TS code (src/dock.ts) creates the separator before appending the first system or pinned item, so when no menu items precede that cluster the separator becomes the dock's `:first-child`. Hide it in that case via CSS — covers both the horizontal taskbar and the vertical dock without touching the rendering logic.
|
Hi! Thanks for the review and the screenshots — they made the regression easy to spot. Pushed cfc786e which hides the separator when it's the first child of the dock. The TS code creates the system/pinned separator before its first cluster item, so when the dock has no menu items above (clean WP install) the separator becomes the first child and now display: none kicks in. Verified both scenarios on Chrome, Firefox and Safari:
|
…arator-styling # Conflicts: # assets/css/dock.css
After PR WordPress#31 unified dock + taskbar with the new `data-wp-desktop-dock-placement` attribute, the bottom-placement separator inherited `height: 60%` which collapses against the floating pill's intrinsic height — leaving the hairline effectively invisible against the translucent backdrop. Set a fixed 28px height to match the dock tile inner glyph area, restoring the same visibility intent of the earlier horizontal taskbar fix on the new selector.
|
Pushed Also rebased onto current Ready for another look! |
AllTerrainDeveloper
left a comment
There was a problem hiding this comment.
Looks great now!



