fix: sync package-lock.json engines.node with package.json - #413
Merged
Conversation
Lockfile still had the pre-Node-25-pin engines range, which caused older npm installs to silently keep a stale @wordpress/env and other mismatched deps around.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package-lock.json's rootengines.nodewas stale (>=24.0.0), out of sync withpackage.json's>=24.0.0 <25.0.0. Runningnpm installagainst a stale lockfile can silently leave older dependency versions in place (this is how@wordpress/envended up pinned at10.39.0locally instead of the^11.7.0the repo requires).Test plan
npm installregenerates the lockfile with no further diffWP_ENV_PORT=8894 npm run env:startsucceeds