Add Popup Siege as a Desktop Mode game extension - #450
Merged
AllTerrainDeveloper merged 2 commits intoJul 31, 2026
Conversation
AllTerrainDeveloper
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
desktop-mode-popup-siegecompanion pluginWhy
Popup Siege was complete as an OpenStation Game Lab release, but it was still wrapped in the broader lab plugin. This packages the exact game as an independently installable Desktop Mode extension and uses the current public game contract rather than carrying the old lab compatibility layer.
Implementation notes
init; the adapter and game runtime remain lazy until the player presses Play..distignorekeeps tests, build inputs, and evidence in the repository while producing a 1.4 MB installable zip containing only runtime files.bin/package-extensions.shnow accepts an optional extension slug so CI can package and inspect that exact artifact without fetching unrelated extension vendors.Testing
npm run buildnpm run lintnpx tsc --noEmitnpm run test:js— 2,499 passednpm --prefix extensions/desktop-mode-popup-siege run check— deterministic rebuild, pinned hashes, and JS syntax passednode --test extensions/desktop-mode-popup-siege/tests/*.test.js— 41 passedphp extensions/desktop-mode-popup-siege/tests/registration-smoke.php— passednpm run test:php— 1,678 passed, 4,295 assertions, 3 expected skips./bin/package-extensions.sh <out> desktop-mode-popup-siege; zip integrity and production inventory checkedpopup-siege, five score columns, asset version 0.7.0, and lazy script registration without eager enqueueReviewer QA
./bin/package-extensions.sh /tmp/popup-siege-pr desktop-mode-popup-siege./tmp/popup-siege-pr/desktop-mode-popup-siege.zip.Evidence boundary
The preserved native approval covers one 1536×960 playing-state frame: hierarchy, alignment, legibility, clipping, overlap, and target priority. It does not prove responsive layouts, alternate states, interaction, animation, audio quality, or fun. Fresh unfamiliar-player fun testing and a human audio-listening pass remain explicitly pending.