Dock hover-peek + title-bar menu cleanup + native "Open on startup" - #69
Merged
AllTerrainDeveloper merged 2 commits intoMay 2, 2026
Merged
Conversation
…gs and Recycle Bin - Add built-in renderers for the OS Settings and Recycle Bin windows in the dock peek feature. - Create custom HTML structures for each renderer to enhance visual identity and state representation. - Introduce a mechanism to register built-in renderers and ensure third-party plugins can customize peek card content. - Implement tests to validate the functionality of the dock peek feature, including rendering conditions and interaction behaviors.
AllTerrainDeveloper
enabled auto-merge (squash)
May 2, 2026 14:04
Resolves the desktop.ts import conflict between bug-report (trunk) and the dock-peek built-in renderers (this branch). Also dequeues wp-desktop-dock-peek between admin-bar tests so its transitive wp-desktop-dock dependency doesn't make the chromeless enqueue assertion flake. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
AllTerrainDeveloper
deleted the
fix/enhacements_thumbnails_UX_UI_polishment
branch
May 2, 2026 21:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the dock's legacy
+chip with a hover-reveal peek popover, moves a couple of infrequent title-bar actions into the existing three-dots menu, and makes "Open on startup" actually work for native windows (OS Settings, Recycle Bin, plugin-registered native apps). Adds two extension hooks so plugins can render their own thumbnails inside peek cards. A few small admin-bar polish fixes ride along.Changes
Dock hover-peek (new)
src/dock-peek/— fan-out popover anchored to a dock tile. Shows when the tile has ≥1 open window.--wp-desktop-titlebar-bg-focusedso cards inherit the user's WP profile color scheme (the variables are read off.wp-desktop-shelland inlined on the body-attached popover so they cascade correctly).windowManager.openNew()wrapped indocument.startViewTransition()so the card morphs into the new window.windowManager.focus(win)so the live window jumps to front behind the popover (Mission-Control / Aero-Peek feel).backdrop-filter: blur(28px) saturate(180%)), capped atmin(80vh, 480px)with internal scroll, JS clamp pass to keep the popover inside the viewport.+chip on multi tiles; chip code removed fromsrc/dock.ts.Title-bar three-dots menu
<Page>" which uses the landing URL)."Open on startup" works for native windows
native:<slug>marker form for the saved preference. PHP validator accepts it (slug constrained to^[a-z0-9_-]+$); portal redirect falls back toadmin_url()when it sees the marker (markers aren't HTTP-redirectable).native:${win.id}for native windows; boot flow detects the marker and opens the right window after init. Built-in OS Settings is opened via its local closure; plugin-registered native windows go throughnativeWindows.openById.refreshStartupCheckState.Admin-bar polish
#72aee6blue — theycolor: inheritand pick up the user's profile color scheme.inline-flex+ 1px optical nudge).$css = '…'were terminating the single-quoted string. Lesson logged in memory.New hooks (plugin extension points)
wp-desktop.dock.peek-card-content(body: HTMLElement, { window, item }) => HTMLElementwp-desktop.dock.peek-card-element(card: HTMLElement, { window, item }) => HTMLElementpeek-card-contentswaps just the card body (default mini-window chrome stays).peek-card-elementreplaces the whole card — plugin owns chrome and click wiring; thewp-desktop-dock-peek__cardclass must be preserved (the fan-out animation keys off it).Test plan
prefers-reduced-motion: no card animations, no breathing pulse, no spring magnify.desktop_mode_validate_default_window_urlacceptsnative:<slug>, rejectsnative:,native:foo bar,native:foo/bar,native:../etc/passwd.Files