Add CI check for uncommitted migrations

[sarayourfriend]

Fixes

Fixes #571 by @sarayourfriend

Description

Adds a new check to verify there are no uncommitted migrations in the PR.

Testing Instructions

Verify that the test commit (43c8c2c) introduces uncommitted migrations and that the CI fails for that commit.

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• [N/A] I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• [N/A] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[AetherUnbound]

It looks like the most recent CI run failed because it was unable to run the just command, not because of an uncommitted migration 🤔

[sarayourfriend]

It looks like the most recent CI run failed because it was unable to run the just command, not because of an uncommitted migration thinking

Yes, so far it still hasn't run correctly. I only undrafted this so I could get the CI to run, please ignore for now!

[AetherUnbound]

Yes, so far it still hasn't run correctly. I only undrafted this so I could get the CI to run, please ignore for now!

Oh got it, my bad! I didn't realize/remember CI doesn't run on drafts

[sarayourfriend]

Seems like the TTY value in the docker-compose won't work for CI 🤔 Why does it work for running the tests?

[sarayourfriend]

This run shows it working to pass when there are no uncommitted migrations: https://github.com/WordPress/openverse-api/runs/5680076354

The run was a mistake but at least it proves that it works 🙂

The next run will show what happens when it should break.

[AetherUnbound]

Smart!

[sarayourfriend]

@AetherUnbound @obulat @stacimc this is ready for review now.

You can see that the workflow correctly fails when there are uncommitted migrations: https://github.com/WordPress/openverse-api/runs/5680410997?check_suite_focus=true

And passes when a new migration is added: https://github.com/WordPress/openverse-api/runs/5680076354

[AetherUnbound]

This is awesome 🎉 great work!

[AetherUnbound]

Thank you for this!!

[stacimc]

🎉 Excited to see this go in!