This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Specify service when running test recipe#628
Merged
AetherUnbound merged 1 commit intomainfrom Apr 5, 2022
Merged
Conversation
stacimc
approved these changes
Apr 5, 2022
Contributor
stacimc
left a comment
There was a problem hiding this comment.
Passing locally for me, looks good! Good catch.
zackkrida
approved these changes
Apr 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Addresses an issue that was introduced in #580
Description
This PR re-adds a parameter to the
just api-testrecipe so that the API tests can run appropriately. When thewebservice was not specified, the recipe dependencies would run and then the recipe would exit out without an error code as soon as it hit thedocker-compose exec ./test/run_test.shstep.Testing Instructions
just api-testshould run tests appropriately and display testing output.Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin