Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Specify service when running test recipe#628

Merged
AetherUnbound merged 1 commit intomainfrom
hotfix/ci-test-running
Apr 5, 2022
Merged

Specify service when running test recipe#628
AetherUnbound merged 1 commit intomainfrom
hotfix/ci-test-running

Conversation

@AetherUnbound
Copy link
Contributor

Fixes

Addresses an issue that was introduced in #580

Description

This PR re-adds a parameter to the just api-test recipe so that the API tests can run appropriately. When the web service was not specified, the recipe dependencies would run and then the recipe would exit out without an error code as soon as it hit the docker-compose exec ./test/run_test.sh step.

Testing Instructions

just api-test should run tests appropriately and display testing output.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested a review from a team as a code owner April 5, 2022 22:29
@AetherUnbound AetherUnbound requested review from dhruvkb and stacimc April 5, 2022 22:29
@AetherUnbound AetherUnbound added 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🤖 aspect: dx Concerns developers' experience with the codebase labels Apr 5, 2022
Copy link
Contributor

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing locally for me, looks good! Good catch.

@AetherUnbound AetherUnbound merged commit 409eea0 into main Apr 5, 2022
@AetherUnbound AetherUnbound deleted the hotfix/ci-test-running branch April 5, 2022 23:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants