Update bug_report.md to remove Expectation section#197
Merged
Conversation
stacimc
approved these changes
Mar 24, 2022
Collaborator
stacimc
left a comment
There was a problem hiding this comment.
LGTM! I agree that section tends to be unused or just repeating yourself.
dhruvkb
approved these changes
Mar 25, 2022
Member
dhruvkb
left a comment
There was a problem hiding this comment.
Looks good, maybe we should add an instruction to describe both the incorrect as well as the correct behaviour in the description itself.
Collaborator
|
Agree with @dhruvkb's suggestion. Especially for people who aren't used to filing bug reports it's not necessarily obvious that it should include the expected behavior, so the description isn't always going to have it. |
AetherUnbound
approved these changes
Mar 25, 2022
Collaborator
AetherUnbound
left a comment
There was a problem hiding this comment.
+1 to additional instructions, but I'm fine jettisoning this section!
Member
Author
|
Added more detail and an example to the 'Description' section. |
dhruvkb
added a commit
that referenced
this pull request
Feb 20, 2023
dhruvkb
added a commit
that referenced
this pull request
Feb 20, 2023
Ignore Storybook files in Prettier
dhruvkb
pushed a commit
that referenced
this pull request
Apr 14, 2023
Make Wikimedia script download audio in addition to images Add popularity metric Stop downloading items with unclear license status Public domain marks in Wikimedia should be explored more Update openverse_catalog/dags/provider_api_scripts/wikimedia_commons.py Distinguish wikimedia_audio provider from wikimedia (image provider) Signed-off-by: Olga Bulat <obulat@gmail.com> Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #140 by @zackkrida
Description
Removes the
Expectationheader from the bug report template.Testing Instructions
View the
.mdfile and confirm the correct appearance.Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin