Update feature_request.md label template to remove priority and aspect#202
Merged
Update feature_request.md label template to remove priority and aspect#202
Conversation
zackkrida
changed the title
dhruvkb
added
the
🚦 status: awaiting triage
sarayourfriend
approved these changes
Mar 25, 2022
Collaborator
sarayourfriend
left a comment
sarayourfriend
left a comment
There was a problem hiding this comment.
LGTM. At this point, since we are removing these, even improvement could be dubious considering it could be an "internal" improvement as well 🙂
AetherUnbound
approved these changes
Mar 25, 2022
Collaborator
AetherUnbound
left a comment
AetherUnbound
left a comment
There was a problem hiding this comment.
Agreed on the improvement note, I think that can go too 🙂
Member
Author
|
I'm fine with removing improvement, just trying to think of how we could reasonably get a list of all of our feature requests without it, if we ever wanted that 🤔 |
Member
|
I vote for keeping the "goal: improvement" label, hard to assume an outsider would be raising an internal improvement feature request. If a contributor were opening it, they might be able to change the label to whatever they deem appropriate. |
dhruvkb
added a commit
that referenced
this pull request
Feb 20, 2023
dhruvkb
added a commit
that referenced
this pull request
Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes priority and aspect labels from the feature request template.